Sourcery refactored main branch

[sourcery-ai]

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function _load_dict refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)
• Merge else clause's nested if statement into elif (merge-else-if-into-elif)

[sourcery-ai]

Function _decompose refactored with the following changes:

• Merge else clause's nested if statement into elif (merge-else-if-into-elif)

This removes the following comments ( why? ):

# with capital letter
#print(part1, part2, affixlen, count, newcandidate)
# even greedier

[sourcery-ai]

Function is_known refactored with the following changes:

• Use any() instead of for loop (use-any)

[codecov-commenter]

Codecov Report

Merging #4 (7f9445a) into main (c70cfef) will decrease coverage by 0.10%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   92.63%   92.52%   -0.11%     
==========================================
  Files           4        4              
  Lines         285      281       -4     
==========================================
- Hits          264      260       -4     
  Misses         21       21              

Impacted Files	Coverage Δ
simplemma/simplemma.py	90.23% <82.35%> (-0.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70cfef...7f9445a. Read the comment docs.

[adbar]

TODO: to review after tests have been added.

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.43%.

Quality metrics	Before	After	Change
Complexity	14.21 🙂	13.76 🙂	-0.45 👍
Method Length	71.75 🙂	71.50 🙂	-0.25 👍
Working memory	10.00 😞	9.96 😞	-0.04 👍
Quality	59.21% 🙂	59.64% 🙂	0.43% 👍

Other metrics	Before	After	Change
Lines	310	308	-2

Changed files	Quality Before	Quality After	Quality Change
simplemma/simplemma.py	59.21% 🙂	59.64% 🙂	0.43% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
simplemma/simplemma.py	_decompose	43 ⛔	237 ⛔	16 ⛔	18.34% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
simplemma/simplemma.py	_read_dict	22 😞	239 ⛔	19 ⛔	24.97% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
simplemma/simplemma.py	_dehyphen	13 🙂	113 🙂	12 😞	51.26% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!