Extra unwanted space after page content

[francisceril]

I'm having an extra space after all my contents/footer. I think its because of the div.sb-site calculating its min-height giving a big white space after the footer.

[adchsm]

Hi Francis,

The plugin sets the minimum height of #sb-site to be as tall as the current screen. This is done to ensure the Slidebars underneath are not visible, unless opened.

For example, if your site content was 500px high, and the screen you were viewing it on was 900px high, you'd see 400px of the Slidebars below the site.

If you've styled a background-color or background-image to the html or body, why not try applying that styling to #sb-site instead?

Please let me know if that helps.

Thanks, Adam

[francisceril]

"For example, if your site content was 500px high, and the screen you were viewing it on was 900px high, you'd see 400px of the Slidebars below the site."

I do have a content taller than the screen. I'm working on a page with 4 sections with atleast 500px height each of them. The extra space I'm having is as tall as the screen height/viewport height.

I've read an article which says it uses your plugin but I think its not having this big space. Here's the link of the site..http://www.caffeineinformer.com/

I have also noticed that my for my site the div.sb-site gives a 1740px min-height and doesnt change at all even if I resize my browser. While the site I linked above is about 635px min-height and changes when I resize the browser.

Did they modify your plugin or maybe there's something wrong with mine? Thanks

[adchsm]

Do you have an example of this I can see? It will help me to understand why this may be happening.

[adchsm]

Yep, that is not supposed to happen. Thanks for bringing that to my attention, I'll work on a fix for it and keep you updated here.

[francisceril]

Thanks..

[adchsm]

I've found the error and fixed it! Thank you for finding this :)

I'll test it over the next few days, so expect a release early next week.

[francisceril]

Cool! Thanks.

[adchsm]

Hey there,

0.8.2 is now out and fixes this issue. Thanks for letting me know about it!

Adam

[Kurre]

For me, this problem occured even with version 0.8.2.

When I looked closer to it, I noticed that the problem was (at least for me), that the script ran before the whole content of the page was loaded. So:

var minHeight = $('html').css('height');

will get wrong value.

In my case, problem was solved by changing my init_slidebars.js to use:

$(window).load(function()

instead of:

$(document).ready(function()

This problem probably has something to do with the site layout, but can't tell for sure, and I can't give a link for it since it's still WIP.

As a reference:

window.load -> minHeight: 2849px
document.ready -> minHeight: 3161px

And same needs to be done to slidebars-theme.js, otherwise it won't load (obviously).

Just came to my mind to post what I noticed as a heads-up.

[adchsm]

Hey there,

Thanks for bring this up, I'll look into this further and re-open it as still seems to be causing problem.

Perhaps document height may provide a more reliable result.

Thanks, Adam

Thanks, Adam

[adchsm]

Hi All,

Version 0.9 is now out, and addresses this issue.

Thanks,

Adam

[danieljameswilliams]

Hello, i am using version 0.9, however i am still getting this issue:
http://ravnsmagasin.dk/shop/frontpage.html

What might I be doing wrong?

[adchsm]

Hi Daniel,

Sorry to hear this is still happening! I can't really see your site though, just the 'opening soon' message.

Is this correct?

Thanks, Adam

[danieljameswilliams]

I fixed it by just removing the min-height lines in the js - does this have any affect, i can't seem to find any?

[adchsm]

This simply ensures the page is at least as tall as the screen its being viewed on. This stops the Slidebar underneath being visible if their isn't enough content on the page.

[pavsid]

I just added the CSS #sb-site { min-height:100%!important; } which seems to have fixed the issue, as it overwrites any min-height set by the plugin

[adchsm]

Hi all,

This issue should be fixed in the upcoming 0.10 version.

Thanks, Adam

[overcatbe]

howdy, still having this issue. i am using the https://github.com/JoryHogeveen/off-canvas-sidebars/issues/new?template=bug_report.md.