Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chapter support #485

Open
dagwieers opened this issue Sep 6, 2019 · 4 comments
Open

Add chapter support #485

dagwieers opened this issue Sep 6, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed kodi Related to the Kodi media player reported This issue has been reported to upstream project

Comments

@dagwieers
Copy link
Collaborator

dagwieers commented Sep 6, 2019

Some video content includes chapters, this allows the user to jump directly to another offset in the video. In Kodi the Up and Down arrows are used to jump from one chapter to the next or previous chapter.

It would be nice if we could implement chapters in Kodi.

@dagwieers dagwieers added enhancement New feature or request help wanted Extra attention is needed labels Sep 6, 2019
@dagwieers dagwieers added this to the v2.2.3 milestone Sep 6, 2019
@dagwieers
Copy link
Collaborator Author

The metadata for video content looks like this:

{
...
    "chapters": [
        {
            "startTime": 56,
            "title": "Lerarentekort",
            "id": "8a5ad532-cf67-4e62-b5e7-43af03d4b93d",
            "externalImageUrl": null,
            "duration": "00:10:57",
            "thumbnail": ".thumb.319.319.png",
            "formattedStartTime": "00:00:56",
            "startTimeInMillis": 56353
        },
        {
            "startTime": 713,
            "title": "Sociaal Incapabele Michiel",
            "id": "76303240-6ff4-4ef3-9f2b-c1e7ce1e8438",
            "externalImageUrl": null,
            "duration": "00:05:04",
            "thumbnail": ".thumb.319.319.png",
            "formattedStartTime": "00:11:53",
            "startTimeInMillis": 713485
        },
        {
            "startTime": 1017,
            "title": "De aangever van Alex Agnew",
            "id": "3ab0cb0d-facb-463a-b75b-bbc761b3ad74",
            "externalImageUrl": null,
            "duration": "00:01:27",
            "thumbnail": ".thumb.319.319.png",
            "formattedStartTime": "00:16:57",
            "startTimeInMillis": 1017987
        },
...
    ],
...
    "programName": "de-ideale-wereld",
...
    "shortDescription": "Met Alex Agnew",
...
    "title": "Alex Agnew",
}

@dagwieers
Copy link
Collaborator Author

dagwieers commented Sep 6, 2019

It appears that this is not possible to add this to video content. The implementation in Kodi only supports chapter-markers already present in video files, so it cannot be added currently to a video stream.

Ideally the Kodi python interface supports a method ListItem.setChapters():

    listitem.setChapters([
        dict(starttime=56, label='Lerarentekort', thumb='https://foo.bar/thumbnail/some_thumb.png'),
        dict(starttime=713, label='Sociaal Incapabele Michiel', thumb='https://foo.bar/thumbnail/another_thumb2.png'),
    ])

@dagwieers dagwieers added the kodi Related to the Kodi media player label Sep 6, 2019
@dagwieers dagwieers added the reported This issue has been reported to upstream project label Sep 7, 2019
@dagwieers
Copy link
Collaborator Author

dagwieers commented Sep 7, 2019

So in Kodi 19 (Matrix) we have chapter support for streams, but currently the python-interface to make use of this from a python add-on is missing.

I opened a feature request upstream at https://forum.kodi.tv/showthread.php?tid=347080

@dagwieers dagwieers modified the milestones: v2.2.3, Future Sep 10, 2019
@dagwieers
Copy link
Collaborator Author

The chapter support was backported to Leia in xbmc/xbmc#16977

@dagwieers dagwieers removed this from the Future milestone Jan 16, 2020
@dagwieers dagwieers moved this from To do to Reported in Kodi issues follow-up Apr 10, 2020
@dagwieers dagwieers moved this from Reported to To do in Kodi issues follow-up Apr 10, 2020
@dagwieers dagwieers moved this from To do to Reported in Kodi issues follow-up Apr 10, 2020
@dagwieers dagwieers moved this from Reported to To do in Kodi issues follow-up Apr 11, 2020
@dagwieers dagwieers moved this from To do to Reported in Kodi issues follow-up Apr 11, 2020
@dagwieers dagwieers removed this from Reported in Kodi issues follow-up Apr 22, 2020
@dagwieers dagwieers moved this from To do to Reported in Kodi feature follow-up Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed kodi Related to the Kodi media player reported This issue has been reported to upstream project
Projects
Development

No branches or pull requests

1 participant