Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

historical_price single_day support #256

Open
jstockdi opened this issue Jan 11, 2021 · 1 comment
Open

historical_price single_day support #256

jstockdi opened this issue Jan 11, 2021 · 1 comment

Comments

@jstockdi
Copy link

jstockdi commented Jan 11, 2021

Summary (include Python version)

In:

self.start, self.end = _sanitize_dates(start, end)

self.end will never be None. Therefore, the single_day property will never be None

return True if self.end is None else False

Is this a bug or should the single day functionality be removed?

Date/time of issue

2021-01-10

Expected behavior

Not setting end_date will treat the request as a single day range

Actual behavior

Setting end_date defaults to today

@jstockdi
Copy link
Author

Possible fix is to make an explicit argument, reflecting the API:
jstockdi@e7b5326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant