You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
"Accessing Model.attributes directly is fine for reading or cloning data, but ideally shouldn't be used to for attribute manipulation." -> Jeremy recommends not touching at Model.attributes at all. For reading or cloning data, he suggests toJSON.
"in scenario where" -> a word is missing
There are minor spacing consistency problems in the fragments of code throughout. For example "_.template( $("#results-template").html());"
In the "What is 'el'?" section you don't emphasize that you can use a combination of the methods to define el
"render() is a function that should always be overridden" -> render() is optional
That's all for now. Let me know if this is useful.
The text was updated successfully, but these errors were encountered:
@JustinDrake Very useful. Thanks so much for putting these together.
I'll focus on getting as many of the items on your list addressed for tomorrow's round of updates as possible. I don't believe there's anything here that I disagree with at all.
I've made some updates to cover 1, 2, 3, 4, 5, 7 and 8.
In terms of 6, I think you make a valid point about spacing. I was considering following the jQuery style guidelines for general spacing across most of the book (which would require a further update), however I'm not sure how well this balances with how most Backbone developers style their code.
Consider expanding "qSA" for the new-comer.
"It's considered optional" -> it is optional?
"title = myPhoto.get("title")" -> too many spaces
"Accessing Model.attributes directly is fine for reading or cloning data, but ideally shouldn't be used to for attribute manipulation." -> Jeremy recommends not touching at Model.attributes at all. For reading or cloning data, he suggests toJSON.
"in scenario where" -> a word is missing
There are minor spacing consistency problems in the fragments of code throughout. For example "_.template( $("#results-template").html());"
In the "What is 'el'?" section you don't emphasize that you can use a combination of the methods to define el
"render() is a function that should always be overridden" -> render() is optional
That's all for now. Let me know if this is useful.
The text was updated successfully, but these errors were encountered: