New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated CSS is big #555
Comments
Hey, thanks for using critical:-) |
Hello, Just use the above config, as I was just using that and nothing more. And try it on css-tricks.com first, you will be able to reproduce that. |
Hey @vardanabhanot, i tried with css-tricks and i got the same error. The error is caused by an invalid inlined stylesheet This is fixed in the linked PR. |
Would you test again using the latest version v5.1.0? |
Look like the tool includes all declaration (even overwritten ones) for every element in the above-the-fold area. |
@onlinebizsoft could you try again with v5.2.0 |
I'm closing this due to lack of feedback. |
Sorry I missed the new option. Let me check and get back when I have the result. |
So I tried to generate critical CSS, but the CSS is like 30,000 characters big. And I tested it with css-tricks.com and it was giving error.
the error I am getting with css-tricks.com is
/index.html.css:2:4: Unknown word
And the configuration I am using is
generate({ base: "critical_css/" + basename, src: url, target: { css: "critical.css", }, width: 1300, height: 900, extract: true, });
Do I need to do something in the config to make it work?
And it is also including inlined CSS too
The text was updated successfully, but these errors were encountered: