Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian Translation strings.xml #245

Closed
OpenWarp opened this issue May 2, 2021 · 18 comments
Closed

Russian Translation strings.xml #245

OpenWarp opened this issue May 2, 2021 · 18 comments

Comments

@OpenWarp
Copy link

OpenWarp commented May 2, 2021

While waiting for approval on Crowdin which may or may not happen I'd like to post translated strings.xml here to speed the things up. In fact, I have created a pull request for it already. Please let me know if you need translated main page https://adeekshith.github.io/watomatic/#/ and the privacy policy, in which case I would appreciate to have original .md files to work with. Thanks.
strings_ru-rRU.zip

@adeekshith
Copy link
Owner

Hi @OpenWarp 👋😃
Saw your translation PR yesterday and also accepted your Crowdin request a while ago.
Out of town this weekend. Will get to your PR by tomorrow or will add those on Crowdin if you did not do already by tomorrow.

Please let me know if you need translated main page https://adeekshith.github.io/watomatic/#/ and the privacy policy,

That would be great. Really appreciate it!! I'll figure out how to add these to Crowdin in the future but until then here are the md files:

.md files are at docs/ghpages branch:
https://github.com/adeekshith/watomatic/tree/docs/ghpages/docs

Main page: README.md
Privacy Policy: privacy-policy.md

Thanks a lot!! 😃

@OpenWarp
Copy link
Author

OpenWarp commented May 2, 2021

Thank you so much @adeekshith and sorry for being impatient. Have a good one!

@mawoka-myblock
Copy link
Collaborator

@adeekshith should I create the website also for Russian?

@mawoka-myblock
Copy link
Collaborator

Hi @OpenWarp
Saw your translation PR yesterday and also accepted your Crowdin request a while ago.
Out of town this weekend. Will get to your PR by tomorrow or will add those on Crowdin if you did not do already by tomorrow.

Please let me know if you need translated main page https://adeekshith.github.io/watomatic/#/ and the privacy policy,

That would be great. Really appreciate it!! I'll figure out how to add these to Crowdin in the future but until then here are the md files:

.md files are at docs/ghpages branch:
https://github.com/adeekshith/watomatic/tree/docs/ghpages/docs

Main page: README.md
Privacy Policy: privacy-policy.md

Thanks a lot!!

There is also the _sidebar.md

@OpenWarp
Copy link
Author

OpenWarp commented May 3, 2021

Done translating https://github.com/adeekshith/watomatic/tree/docs/ghpages/docs except for screenshot images and Github privacy policy. The latter is beyond the scope of this project. How do I go about translating images? Please advise.
docs_ru-rRU.zip

@mawoka-myblock
Copy link
Collaborator

Added it in #246

@adeekshith
Copy link
Owner

How do I go about translating images? Please advise.

I could not find a quick way to do that via Crowdin. Will ask them and see if I missed anything.
I should also figure out how to integrate website translations with Crowdin. Will do that this week.

Thanks a lot @OpenWarp for the translations and @mawoka-myblock for adding it to the website 😃🙌

@mawoka-myblock
Copy link
Collaborator

Is live on the website! Good job, @OpenWarp

@OpenWarp
Copy link
Author

OpenWarp commented May 9, 2021

@mawoka-myblock Thank you so much and may I suggest the hard to notice "Translations" link in the top right-hand corner to be replaced with the flag icon plus a short language name (EN, DE, RU, and so on). Then it's up to you to either put the flags in one line since there are few or to make it a drop down list. And would you be so kind to make sure Russian language reads "Русский" and not "Russia." Thanks.

@mawoka-myblock
Copy link
Collaborator

Will have a look at it. Maybe tomorrow!

@adeekshith
Copy link
Owner

adeekshith commented May 10, 2021

@OpenWarp How is "Russian" written in Russian? Is this correct: "русский"

Ignore, found my answer in your previous message

@mawoka-myblock
Copy link
Collaborator

mawoka-myblock commented May 10, 2021

@mawoka-myblock Thank you so much and may I suggest the hard to notice "Translations" link in the top right-hand corner to be replaced with the flag icon plus a short language name (EN, DE, RU, and so on). Then it's up to you to either put the flags in one line since there are few or to make it a drop down list. And would you be so kind to make sure Russian language reads "Русский" and not "Russia." Thanks.

@OpenWarp Which flag should I take for the translation-button?

@adeekshith
Copy link
Owner

@mawoka-myblock Thank you so much and may I suggest the hard to notice "Translations" link in the top right-hand corner to be replaced with the flag icon plus a short language name (EN, DE, RU, and so on). Then it's up to you to either put the flags in one line since there are few or to make it a drop down list. And would you be so kind to make sure Russian language reads "Русский" and not "Russia." Thanks.

@OpenWarp Which flag should I take for the translation-button?

I think just the localized language name and code should do for now.

Like this:

English (EN)
Deutsche (DE)
Русский (RU)

But if you like the idea of flags:
🇺🇸 English (EN)
🇩🇪 Deutsche (DE)
🇷🇺 Русский (RU)

I am slightly reluctant with idea of flags on the website as some languages are equally popular in more than one countries. Example, Tamil is equally spoken in India and Sri Lanka. So we might run into conflicts but not totally against it. So if you think it is the right thing to do, go ahead :)

@OpenWarp
Copy link
Author

Great job @mawoka-myblock ! Just updated the links in strings.xml via Crowdin, except for privacy policy link which is marked as non-translatable and is therefore hidden by Crowdin.

@adeekshith
Copy link
Owner

Can make the URL translatable but that should not be required. I think we should change the script to auto redirect the link based on browser language.

Also just noticed https://watomatic.app/#/privacy-policy is redirecting to https://watomatic.app/ru/index.html#/ instead of to https://watomatic.app/ru/#/privacy-policy. Fixing this should solve the issue.

Will also add strings required by screenshots to the Android strings.xml so we get translations for that too. 😊

@adeekshith
Copy link
Owner

@OpenWarp Made the privacy policy url translatable 😊

@OpenWarp
Copy link
Author

@adeekshith The url_privacy_policy string does not appear in Crowdin for some reason.

@adeekshith
Copy link
Owner

@adeekshith The url_privacy_policy string does not appear in Crowdin for some reason.

Looks like Crowdin has some issue updating when a String is changed from non-translatable to translatable. Should probably change the string key. But redirecting automatically based on browser language is a better thing to do. Tracking it here: #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants