Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: list structure. #1

Merged
merged 18 commits into from Sep 28, 2022
Merged

To Do list: list structure. #1

merged 18 commits into from Sep 28, 2022

Conversation

adel-gu
Copy link
Owner

@adel-gu adel-gu commented Sep 28, 2022

Accomplishments in this PR 🎯

  • Use webpack repo template to Set up the ToDo list project.
  • Create a tasks.js file to set the array of simple to do tasks (array of objects).
  • Build the Function to iterate over the tasks array and populate an HTML list item element for each task, inside src/module/AppUi.js file.
  • Render the tasks on page load, inside the src/module/base.js file.
  • Style the App, with src/style.css file.

@github-pages github-pages bot temporarily deployed to github-pages September 28, 2022 15:28 Inactive
@github-pages github-pages bot temporarily deployed to github-pages September 28, 2022 15:40 Inactive
@adel-gu adel-gu self-assigned this Sep 28, 2022
Copy link

@KDlamini KDlamini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adel-gu 🙋‍♀️,

Excellent work! 💯
You have done a great job implementing all the project requirements.
Your feature is complete! There is nothing else to say other than... it's time to merge it. :shipit:
Congratulations!!!🎊 🥳

Highlights 🌞

✔️ Correct PR title and description
✔️ Webpack is used to set up the project.
✔️ There's a function that iterates over the tasks array and populates the HTML
✔️ No linter errors

Status: Approved ✔️

LeonardoInGatsby

Cheers 🥂 and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@adel-gu
Copy link
Owner Author

adel-gu commented Sep 28, 2022

Hi @KDlamini 👋

Thanks for reviewing my code 😄👏👏.

@adel-gu adel-gu merged commit 2920118 into master Sep 28, 2022
@adel-gu adel-gu deleted the list-structure branch September 28, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants