Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive list #3

Merged
merged 6 commits into from Sep 30, 2022
Merged

interactive list #3

merged 6 commits into from Sep 30, 2022

Conversation

adel-gu
Copy link
Owner

@adel-gu adel-gu commented Sep 30, 2022

In This PR I implement the changes below ✔

  • Added check.js file to contain methods about the status of the tasks.
  • Added event listener to the checkbox (change).
  • Update the completed Task value when the user checks the task checkbox element.
  • Implement a "Clear all completed " function using the filter method in src/utils/delete.js.
  • Store the updated array of items in local storage

Copy link

@KayLemba KayLemba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 👏

Hello @adel-gu ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

HIGHLIGHTS:

  • Your project is professional
  • Your repo is professional
  • Well structured files
  • No linter errors
  • Proffessional README
  • Neat UI Design 💯

Now you can merge this branch and move on 🥇
Happy Coding cheers 🥇 💯

well-1

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@adel-gu
Copy link
Owner Author

adel-gu commented Sep 30, 2022

Thank you @KayLemba, I really appreciate it 😄

@adel-gu adel-gu merged commit 60365dc into master Sep 30, 2022
@adel-gu adel-gu deleted the interaction branch September 30, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants