canonical urls in comments + variance return type comment

typelevel · Dec 3, 2016 · 07fa5b9 · 07fa5b9
1 parent ad4215e
commit 07fa5b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/core/src/main/scala/frameless/CatalystVariance.scala b/core/src/main/scala/frameless/CatalystVariance.scala
@@ -1,8 +1,7 @@
 package frameless
 
 /**
-  * When taking variance, Spark doesn't change this type:
-  * - Double     -> Double
+  * Spark's variance and stddev functions always return Double
   */
 trait CatalystVariance[T]
 

diff --git a/dataset/src/main/scala/frameless/functions/AggregateFunctions.scala b/dataset/src/main/scala/frameless/functions/AggregateFunctions.scala
@@ -41,13 +41,13 @@ trait AggregateFunctions {
   }
 
   // In Spark variance always returns Double
-  // https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala#186
+  // https://github.com/apache/spark/blob/4a3c09601ba69f7d49d1946bb6f20f5cfe453031/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala#186
   def variance[A: CatalystVariance, T](column: TypedColumn[T, A]): TypedAggregateAndColumn[T, Double, Option[Double]] = {
     new TypedAggregateAndColumn[T, Double, Option[Double]](untyped.variance(column.untyped))
   }
 
   // In Spark stddev always returns Double
-  // https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala#155
+  // https://github.com/apache/spark/blob/4a3c09601ba69f7d49d1946bb6f20f5cfe453031/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala#155
   def stddev[A: CatalystVariance, T](column: TypedColumn[T, A]): TypedAggregateAndColumn[T, Double, Option[Double]] = {
     new TypedAggregateAndColumn[T, Double, Option[Double]](untyped.stddev(column.untyped))
   }