Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generates invalid HTML #19

Closed
Merri opened this issue Jul 10, 2015 · 3 comments
Closed

Generates invalid HTML #19

Merri opened this issue Jul 10, 2015 · 3 comments

Comments

@Merri
Copy link
Contributor

Merri commented Jul 10, 2015

Current implementation generates ul and span elements as direct children of ul, which is against the spec.
@AdeleD
Copy link
Owner

AdeleD commented Jul 16, 2015

There are no span elements as direct children of ul on the current version. Are you sure you're using the last one?

@mikew
Copy link

mikew commented Jul 29, 2015

This is what I'm seeing with React v0.13.3 and the latest version of your component.

screen shot 2015-07-29 at 12 22 39 pm

There's definitely a span directly under the ul

In your sample/sample.jsx, you're using breakLabel={<li className="break"><a href="">...</a></li>}, which obviously inserts the li

@AdeleD
Copy link
Owner

AdeleD commented Jul 29, 2015

Oh ok, I see. You're right, I will fix this.

ianoxley added a commit to ianoxley/react-paginate that referenced this issue Dec 17, 2015
@ianoxley
Wrapped PaginationListView in <li> tag.
941c926 
Fix for AdeleD#19.

Wrapped the PaginationListView component in an `<li>` tag so the
PaginationListView's `<ul>` tag isn't a direct child of the
PaginationBoxView's `<ul>` tag.
@ianoxley ianoxley mentioned this issue Dec 17, 2015
Merged
@AdeleD AdeleD closed this as completed in 325a13d Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikew @AdeleD @Merri