Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only calculate partition access #38

Closed
teknoid opened this issue Dec 30, 2020 · 7 comments · Fixed by #48
Closed

only calculate partition access #38

teknoid opened this issue Dec 30, 2020 · 7 comments · Fixed by #48
Labels
enhancement New feature or request

Comments

@teknoid
Copy link

teknoid commented Dec 30, 2020

Hi Adelolmo,

I have installed monitorix to watch my system, incl. disk temp and smart reporting. The data collection script runs every minute but this increase the diskstats counters for the disk devices (sda, sdb, etc...)

Thats why hd-idle never spins down the devices even if there is no disk activity on it's partitions.

Could you please add a config switch that ignores the device entry in /proc/diskstats and counts only the partition entries sda1...sdaX? Or make this the (IMHO) default behavior and add a config switch to include the device entry.

Thanks and best regards
Heiko

@adelolmo adelolmo added the enhancement New feature or request label Jan 9, 2021
@eloo
Copy link

eloo commented Mar 7, 2021

Hi,
just found that issue and i can confirm that checking only the disk will cause disk from spinning down.
In my case smartctl -n standy seems also to change the counts for the disks.

But i'm curious what will happen if we configure in hd-idle sda1 instead of sda?

@adelolmo
Copy link
Owner

@eloo
Currently you have to provide devices and not partitions.

@eloo
Copy link

eloo commented Mar 15, 2021

@adelolmo
okay.. do you think it would be possible to use a partition there? so to adjust the regex there?

i've quickly tested/checked the stats file for the partition and it looks like it could work without any big changes

@mindrunner
Copy link

It seems like this is an issue only in more recent kernels. Similar problem here:

desbma/hddfancontrol#28

Unfortunately, there is currently no way to have disk monitoring set up (temps, smart, power state) and spin down drives when Idle. (Workaround: Use 5.4 LTS)

The partition thing sounds like a good idea. I would love to see that, too

@teknoid
Copy link
Author

teknoid commented Mar 23, 2021

Indeed I was thinking that it worked in the past. But I did not recognize that kernel update might be the reason.

@mindrunner
Copy link

Checking back in to confirm that this indeed solves my problem. Disks spinning down again with more recent kernels!

@eloo
Copy link

eloo commented Apr 6, 2021

I can also confirm that its now working as expected.
Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants