Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website/previews): fix copy and paste for colors and icons & previews height #429

Merged
merged 1 commit into from Nov 20, 2019

Conversation

mohamedMok
Copy link
Contributor

I have read the contributing guidelines

  • Yes
  • No

Does this PR introduce a breaking change?

read What is a breaking change ?

  • Yes
  • No

Describe the changes

Github issue number or Jira issue URL:
https://design-system-adeo.atlassian.net/browse/MZC-227
https://design-system-adeo.atlassian.net/browse/MZC-226

Other informations

Screen Shot 2019-11-19 at 5 32 27 PM

@mohamedMok mohamedMok added 🧯 fix A bug fix scope:website Anything related to the documentation website labels Nov 19, 2019
@gael-boyenval gael-boyenval temporarily deployed to staging November 19, 2019 16:39 Inactive
Copy link
Contributor

@gael-boyenval gael-boyenval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview now instead of scrolling hide a part of the content...
Apart from that everything seems in order.
I will make the changes myself to add the icon and fix the iframe height.

@gael-boyenval gael-boyenval force-pushed the fix-previews-and-copytoclipboard branch 2 times, most recently from ea4c85b to 189700e Compare November 20, 2019 13:24
@gael-boyenval gael-boyenval temporarily deployed to staging November 20, 2019 13:37 Inactive
@gael-boyenval gael-boyenval merged commit 6042dd7 into master Nov 20, 2019
@gael-boyenval gael-boyenval deleted the fix-previews-and-copytoclipboard branch November 20, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧯 fix A bug fix scope:website Anything related to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants