feat(layer/zodio): adapt size #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
temporarily deployed
to
staging
tiloyi
approved these changes
May 4, 2023
| @@ -39,28 +39,28 @@ | |||
| width: 100%; | |||
|
|
|||
| @include set-from-screen("m") { | |||
| max-width: 25rem; // 400px | |||
| max-width: $layer-max-width-m; // 400px | |||
There was a problem hiding this comment.
From my point of view, we don't have to put in variables, as the values are only used once, and the size does not change depending on the preset.
So we could also have done :
max-width: 25rem; // 400px => max-width: px-to-rem(400);
But the evolution made works, so that's the most important thing :)
There was a problem hiding this comment.
Thanks for the feedback I will make the changes before merging :)
tiloyi
pushed a commit
that referenced
this pull request
Jun 2, 2023
tiloyi
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the contributing guidelines
Does this PR introduce a breaking change?
Describe the changes
GitHub issue number or Jira issue URL: N/A
Other information