Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component/accordion): clean & improve component styles #1511

Merged
merged 1 commit into from Nov 6, 2023

Conversation

tiloyi
Copy link
Contributor

@tiloyi tiloyi commented Nov 6, 2023

I have read the contributing guidelines

  • Yes
  • No

Does this PR introduce a breaking change?

  • Yes
  • No

Describe the changes

Clean & improve component styles

This PR includes the following changes:

  • Removal of the code for the old accordion structure
  • Improved behaviour when elements are inserted before the label (checkbox / toggle)
  • Improved no-padding behaviour

GitHub issue number or Jira issue URL

Other information

PR brought back from https://github.com/adeo/ads-styles/pull/18

@tiloyi tiloyi self-assigned this Nov 6, 2023
@tiloyi tiloyi added 🚀 feat A new feature scope:component Anything related to a component labels Nov 6, 2023
@SimonCfn
Copy link

SimonCfn commented Nov 6, 2023

Logo
Checkmarx One – Scan Summary & Detailsfe3b68e4-2635-4e06-9943-c6b3cbef5660

No New Or Fixed Issues Found

@ghost ghost temporarily deployed to staging November 6, 2023 12:27 Destroyed
@tiloyi tiloyi merged commit d0b7286 into master Nov 6, 2023
2 checks passed
@tiloyi tiloyi deleted the feat/accordion-clean branch November 6, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feat A new feature scope:component Anything related to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants