refactor(patterns/headings): add padding bottom #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caqueste
added
✨ refactor
caqueste
changed the title
ghost
temporarily deployed
to
staging
nherwegh
reviewed
Aug 26, 2020
| @@ -108,6 +108,12 @@ The color of the underline allows you to give visual context to your page or sec | |||
|
|
|||
| <Preview path="typographyHeading-underlines" nude /> | |||
|
|
|||
| #### Bottom padding | |||
|
|
|||
| Headings provide with a default bottom padding to keep a right rythm between the other elements of the interface. | |||
There was a problem hiding this comment.
Padding bottom
Headings include a default padding bottom to maintain layout consistency across breakpoints.
or something like that?
There was a problem hiding this comment.
Here it's a deal about the vertical rhythm inside a page, not about the breakpoints.
There was a problem hiding this comment.
Headings include a default padding bottom to keep the right vertical rhythm between the interface elements.
then 😉
tiloyi
approved these changes
Aug 26, 2020
nherwegh
approved these changes
Aug 26, 2020
caqueste
changed the title
tiloyi
changed the title
mohamedMok
approved these changes
Sep 10, 2020
|
@caqueste didn't we put a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the contributing guidelines
Does this PR introduce a breaking change?
Describe the changes
GitHub issue number or Jira issue URL: N/A
Other information