feat(badge): add badge component code #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedMok
added
🚀 feat
ghost
caqueste
approved these changes
Sep 14, 2021
tiloyi
reviewed
Sep 14, 2021
Comment on lines
21
to
27
| @if map-has-key($props, 'border') { | ||
| border-color: map-get($props, 'border'); | ||
| } | ||
|
|
||
| @if map-has-key($props, 'background') { | ||
| background-color: map-get($props, 'background'); | ||
| } |
There was a problem hiding this comment.
@if map-has-key($props, 'border')
@if map-has-key($props, 'background')
As of there are no borderless versions of badges, it is not necessary to test for the presence of the value.
So you can directly write your code as follow:
@mixin set-badge-theme($props) {
color: map-get($props, "text");
border-color: map-get($props, "border");
background-color: map-get($props, "background");
}
tiloyi
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the contributing guidelines
Does this PR introduce a breaking change?
Describe the changes
GitHub issue number or Jira issue URL: https://jira.adeo.com/browse/MZC-130
Other information