fix(svg): add aria-hidden to svg #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mohamedMok
added
scope:a11y
tiloyi
reviewed
Nov 10, 2021
iconCompiler/svgCleaners/index.js
Outdated
| @@ -51,11 +51,11 @@ const readIcon = (file) => | |||
|
|
|||
| // optimize using SVGO and custom clean options | |||
|
|
|||
| const optimizeIcon = ({ file, data }, SVGOPlugins, customOptims) => | |||
| const optimizeIcon = ({ file, data }, svgoPlugins, customOptims) => | |||
There was a problem hiding this comment.
Is it possible to put the changes in this file in another PR please? In order to separate the commits.
mohamedMok
changed the title
tiloyi
approved these changes
Nov 10, 2021
tiloyi
pushed a commit
that referenced
this pull request
Dec 21, 2021
tiloyi
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the contributing guidelines
Does this PR introduce a breaking change?
Describe the changes
GitHub issue number or Jira issue URL: N/A
Other information