Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Version request] #108

Closed
i240c opened this issue Jul 17, 2023 · 18 comments
Closed

[Version request] #108

i240c opened this issue Jul 17, 2023 · 18 comments
Labels
version request Internally used to tag issues related to precompiled binaries

Comments

@i240c
Copy link

i240c commented Jul 17, 2023

Minecraft version

1.19.3

@i240c i240c added the version request Internally used to tag issues related to precompiled binaries label Jul 17, 2023
@github-actions
Copy link

Build process started. You can follow the build progress here or subscribe to this issue to be notified when binaries are ready.

@i240c
Copy link
Author

i240c commented Jul 17, 2023

Why it failed?

@adepierre
Copy link
Owner

Online test failed, just restarted it to check if it's just a server/client issue that can happen sometimes or if there is a real issue preventing the test to pass. Let's see if it fails again.

@i240c
Copy link
Author

i240c commented Jul 17, 2023

Does it work now?

@adepierre
Copy link
Owner

It failed again. I'll take a look to see if I can reproduce the error locally.

@adepierre
Copy link
Owner

Ok so after checking the error, it seems that it's related to the reading of the server stdout that seems to be blocked. I can't reproduce it locally as it only happens on the github actions machine, and I can't figure out why it blocks only for this version and worked for others 🤔

@i240c
Copy link
Author

i240c commented Jul 18, 2023

Weird

@i240c
Copy link
Author

i240c commented Jul 18, 2023

1.19 versions seem to not work for some reason

@adepierre
Copy link
Owner

adepierre commented Jul 18, 2023

Yeah but for different reasons.

1.19.3 has the issue during the online tests
1.19.2 was a github error during the issue processing, so the build process was not even started (you can try close and reopen the corresponding issue to restart it) -->it has the same compilation error than 1.19.1
1.19.1 has a compilation issue, I should be able to fix this one

@i240c
Copy link
Author

i240c commented Jul 18, 2023

Mind updating me when you manage to fix one of the 1.19 versions?

@adepierre
Copy link
Owner

adepierre commented Jul 18, 2023

Sure! It should be good with August update. Will keep this issue open and notify you here when it's released.

@github-actions
Copy link

Build process started. You can follow the build progress here or subscribe to this issue to be notified when binaries are ready.

@github-actions
Copy link

Build failed. Logs can be found here.

@adepierre you might want to take a look.

@github-actions
Copy link

Build failed. Logs can be found here.
-en
\n
-en
\n
you
might
want
to
take
a
look.

@github-actions
Copy link

Tests failed. See this run for logs.

@adepierre you might want to take a look.

@github-actions
Copy link

Tests failed. See this run for logs.
-en
\n
-en
\n
you
might
want
to
take
a
look.

@github-actions
Copy link

New binaries available in the latest release for version 1.19.3

You can now close this issue. If you need an updated build for the same Minecraft version in the future, you can reopen this issue to trigger a new build instead of creating a new issue.

@adepierre
Copy link
Owner

adepierre commented Aug 12, 2023

@i240c 1.19.3 is working and available in latest release. You can close this issue if it's good for you. If you need again 1.19.3 precompiled in the future you can reopen this one instead of creating a new one.

(I might have an issue with the bot spamming failure though but that's not related to 1.19.3...)

@i240c i240c closed this as completed Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version request Internally used to tag issues related to precompiled binaries
Projects
None yet
Development

No branches or pull requests

2 participants