Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

person-list: Edit person information to right-align #445

Merged

Conversation

FrederikSchlemmer
Copy link
Collaborator

@FrederikSchlemmer FrederikSchlemmer commented Nov 23, 2020

This pull request changes the style of the person list table. The person information is now right-aligned and the year of the date is displayed with four digits.

Note: This Pull Request is based on #433, so first the PR #433 must be merged and then a rebase is necessary.

Closes #440

FrederikSchlemmer and others added 9 commits August 5, 2020 14:59
Instead of returning zero euro when the value isn't assigned we now return the correct value null. This makes money field return the correct value and makes it obvious when there is a null value.
This approach is needed to fit the requirements of the ticket 374.
A new field is added to the PersonEntity, which will be used for a feature in the future. This will allow to set a defaultDailyRate for the person.
This new field needs a database migration, which is also integrated.
This feature lets the user add a default daily rate to each person. According to this default daily rate the missing rates can be automatically be assigned with this rate.
This avoids that the user needs to add each missing rate manually.
Budgets in different projects can have the same name, so looking it up
by name could return more than one result. To fix this we need to look
the budgets up with their id.
When the user adds records manually the automatic feature will potentially overwrite already created records.
That's why the feature is disabled when the user adds a record manually.
@czarnecki czarnecki merged commit 54f5bbb into adessoSE:release Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

People List cosmetics
3 participants