-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
person-list: Edit person information to right-align #445
Merged
czarnecki
merged 10 commits into
adessoSE:release
from
FrederikSchlemmer:design-person-list-table
Dec 9, 2020
Merged
person-list: Edit person information to right-align #445
czarnecki
merged 10 commits into
adessoSE:release
from
FrederikSchlemmer:design-person-list-table
Dec 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning zero euro when the value isn't assigned we now return the correct value null. This makes money field return the correct value and makes it obvious when there is a null value. This approach is needed to fit the requirements of the ticket 374.
A new field is added to the PersonEntity, which will be used for a feature in the future. This will allow to set a defaultDailyRate for the person. This new field needs a database migration, which is also integrated.
This feature lets the user add a default daily rate to each person. According to this default daily rate the missing rates can be automatically be assigned with this rate. This avoids that the user needs to add each missing rate manually.
Budgets in different projects can have the same name, so looking it up by name could return more than one result. To fix this we need to look the budgets up with their id.
When the user adds records manually the automatic feature will potentially overwrite already created records. That's why the feature is disabled when the user adds a record manually.
50260c4
to
f5a5199
Compare
tinne
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the style of the person list table. The person information is now right-aligned and the year of the date is displayed with four digits.
Note: This Pull Request is based on #433, so first the PR #433 must be merged and then a rebase is necessary.
Closes #440