Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll first invalid element into view #733

Merged
merged 3 commits into from
Feb 3, 2022
Merged

feat: scroll first invalid element into view #733

merged 3 commits into from
Feb 3, 2022

Conversation

derrabauke
Copy link
Contributor

This is a naive implementation for scrolling the first invalid element into view after submit has been triggered.

@derrabauke
Copy link
Contributor Author

@czosel you may approve the feature-flag implementation? pleeeze 😸

czosel
czosel approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@czosel czosel force-pushed the feat-scroll-invalid-into-view branch from c8c11da to 87ec3a2 Compare February 3, 2022 16:08
@czosel czosel merged commit ae7c8b2 into adfinis:main Feb 3, 2022
velrest pushed a commit that referenced this pull request Feb 3, 2022
@semantic-release-bot
chore(release): 5.2.0 [skip ci]
cfe3928 
# [5.2.0](v5.1.1...v5.2.0) (2022-02-03)

### Features

* scroll first invalid element into view ([#733](#733)) ([ae7c8b2](ae7c8b2))
* **validated-button:** add `triggerValidations` flag ([#721](#721)) ([765f5f4](765f5f4))
@velrest
Copy link
Contributor

velrest commented Feb 3, 2022

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anehx anehx anehx approved these changes

@czosel czosel czosel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@derrabauke @velrest @anehx @czosel