Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(monitoring): simplify and fix prometheus rule #17

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix(monitoring): simplify and fix prometheus rule #17

merged 1 commit into from
Sep 29, 2021

Conversation

vmaillot
Copy link
Contributor

No description provided.

eni23
eni23 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@eni23 eni23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as its already deployed and tested at one of our customers

@vmaillot vmaillot merged commit 758defc into main Sep 29, 2021
@vmaillot vmaillot deleted the fix/monitoring-rule branch September 29, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eni23 eni23 eni23 approved these changes

@paraenggu paraenggu Awaiting requested review from paraenggu

@hairmare hairmare Awaiting requested review from hairmare

@tongpu tongpu Awaiting requested review from tongpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmaillot @eni23