Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic server addresses with case sensitive device names aren’t being parsed correctly #2320

Closed
5 tasks done
ghost opened this issue Apr 19, 2024 · 4 comments
Closed
5 tasks done

Comments

@ghost
Copy link

ghost commented Apr 19, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.5.3

Environment

  • OS: iOS 17.5
  • Device: iPhone 13 Pro

Ad Blocking

AdGuard Base filter, AdGuard Mobile Ads filter

Privacy

AdGuard Tracking Protection filter

Social

AdGuard Social Media filter

Annoyances

AdGuard Annoyances filter

Security

No response

Other

No response

Language-specific

No response

Advanced protection for Safari

  • yes, I do

Which DNS server do you use?

AdGuard DNS

DNS protocol

DNS-over-QUIC

Custom DNS

quic://John--Router-f8c555.dns.nextdns.io

DNS filtering

  • yes, I do

Custom DNS filter

AdGuard DNS filter

DNS implementation

AdGuard

Tunnel mode

Split-Tunnel

Low-level settings

Bootstrap server: default
Fallback server: default
Blocking mode, etc: default

Issue Details

Steps to reproduce:

  1. Insert quic://John--Router-f8c555.dns.nextdns.io into custom DNS servers
  2. Visit https://test.nextdns.io/
  3. Observe case sensitive device name not respected

Expected Behavior

Case sensitive server addresses are respected.

Actual Behavior

Case sensitive server addresses aren’t respected.

Screenshots

Screenshot 1

Incorrect result when using the below DoQ server address with AdGuard for iOS
IMG_0582

Correct result when using a case sensitive DoQ address in AdGuard VPN
IMG_0583

Additional Information

No response

@sfionov
Copy link
Member

sfionov commented Apr 19, 2024

@jslawler-gh Thank you for report, seems to be regression.

I have to say that it will stop working in AdGuard VPN too if you update, DnsLibs is updated in the upcoming version.

@ghost
Copy link
Author

ghost commented Apr 19, 2024

It seems to be working in AdGuard VPN for iOS 2.3.0, and the latest TestFlight beta (3602) still, unless you're referring to an upcoming update?

@sfionov
Copy link
Member

sfionov commented Apr 19, 2024

@jslawler-gh Yes, I'm talking about upcoming version

@zzebrum
Copy link
Contributor

zzebrum commented Apr 19, 2024

Duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants