Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adguard doesn't filter ads in sub-apps in WebCatalog app #165

Closed
Eugene-Savenko opened this issue Jan 16, 2017 · 7 comments
Closed

Adguard doesn't filter ads in sub-apps in WebCatalog app #165

Eugene-Savenko opened this issue Jan 16, 2017 · 7 comments
Assignees
Milestone

Comments

@Eugene-Savenko
Copy link
Member

Eugene-Savenko commented Jan 16, 2017

https://getwebcatalog.com/ - it allows to launch other apps within WebCatalog app.

It's added to the filtered apps list

image

but ads are still being displayed, for instance, in youtube app

ads

Reproduced on MacOS X 10.12.2, Adguard 1.4.0.

Ticket: 1389893

@Rediwed
Copy link

Rediwed commented Jan 16, 2017

All application traffic within from web-apps within WebCatalog is routed thru /content/MacOS/WebCatalog_Real/, as evident by using Little Snitch to sniff the actual data.

Also, I tried manually adding the web-apps in /Volumes/$user/Applications/WebCatalog\ Apps/ but these applications refused to show up in the filtered application list.

@ameshkov ameshkov added this to the 1.4.1 milestone Jan 16, 2017
@ameshkov
Copy link
Member

ameshkov commented Jan 16, 2017

@Stillness-2 please take a look.

If there are no simple solution, consider adding a workaround specifically for the WebCatalog app.

@Rediwed
Copy link

Rediwed commented Jan 16, 2017

I don't believe this problem to be WebCatalog specific, and thus the title might be misleading.

Any way to proof wether this issue also persists in other applications that do not route traffic thru their xxxx.app but rather thru a Unix executable subsidiary?

@ameshkov
Copy link
Member

As I recall, most of the apps store this kind of executables inside of the *.app dir. Unlike WebCatalog though.

@Rediwed
Copy link

Rediwed commented Jan 16, 2017

@quanglam2807 is the developer of WebCatalog, he might be able to shed some light on this!

@quanglam2807
Copy link

@ameshkov So basically, when an app installed from WebCatalog is launched, it called a bash script to start WebCatalog.

Also, the main executable file of WebCatalog is a bash script, not a binary. (WebCatalog.app is an app bundle with generic not an app bundle with Mach-O thin (x86_64)) So maybe Adguard fails to detect when WebCatalog is running.

This is what I think:

Users app WebCatalog to filtered list. Adguard remembers that when the executable file of WebCatalog is running, block ads). But in reality, the executable file only run in a few seconds to call the real binary file WebCatalog_Real which Adguard does not detect.

I use this approach to trick the macOS because the OS does not allow to launch multi-instance of an app from Launchpad. So by doing this, macOS will think WebCatalog is not running and allow it to run again. You can take a look at the afterPack code https://github.com/webcatalog/desktop/blob/master/packager.js

The solution I can suggest is to add an exception for only WebCatalog. But maybe you guys will find out something better.

@ameshkov
Copy link
Member

@quanglam2807 thank you for clarification!

@Stillness-2 Stillness-2 modified the milestones: 1.4.1, 1.4.2 Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants