Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom filter subscriptions (by URL or file path) #9

Closed
ameshkov opened this issue Jul 19, 2015 · 1 comment
Closed

Adding custom filter subscriptions (by URL or file path) #9

ameshkov opened this issue Jul 19, 2015 · 1 comment

Comments

@ameshkov
Copy link
Member

There should be a possibility to add custom filter subscription by URL or file path.

Requirements

  1. Add custom filters to the same group as user filter.
  2. Handle the situation when users adds custom filter we already have (like EasyList) (use subscription_url field to merge them).
  3. Filter parser should handle "Homepage", "Version", "Expires" fields
  4. We should properly handle filters without such metadata.

If "Homepage" is not set - do not display it.
If "Version" is not set - display something like "Version from 15/01/2015"
Important: Handle empty version on update check result screen.

Parse "Last modified". If not set - use DateTime.Now.
If "Expires" is not set - set it to 48 hours.
Parse "Title". If "Title" not set - use URL instead (cut it to 64 characters)

  1. Ignore [Adblock Plus 2.0] line

UI

  1. New button to "Add filter" dialog:
    http://screencast.com/t/5W0DuQyo
  2. New Filter Subscription dialog:
    http://screencast.com/t/THZmkmbSsPg

User may enter abp:subscribe or subscribe.adblockplus.org URL.
We should handle it.

@ameshkov ameshkov added this to the 6.0 beta milestone Jul 19, 2015
@ameshkov ameshkov modified the milestones: 6.0 release, 6.0 beta Aug 18, 2015
@suhan3z suhan3z closed this as completed Aug 28, 2015
@gshumihin
Copy link

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants