Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping Controllers lean by extracting validation logic. #33

Open
GodwinIyamba opened this issue Jan 2, 2023 · 1 comment
Open

Keeping Controllers lean by extracting validation logic. #33

GodwinIyamba opened this issue Jan 2, 2023 · 1 comment

Comments

@GodwinIyamba
Copy link

GodwinIyamba commented Jan 2, 2023

Hello there,

I went through your codebase and noticed that the controllers had some validation logic in them. I suggest they be extracted, where necessary, and put into appropriate form requests, this way, the Controllers remain lean with just the necessary logic.

@GodwinIyamba GodwinIyamba changed the title Keeping Controllers lean by extracting validatiojn logic. Keeping Controllers lean by extracting validation logic. Jan 2, 2023
@dassudip2001
Copy link

also, create a new record and create a request like

  • php artisan make: request XyzRequest
    and put the validation rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants