Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting the state machines not always correct #13

Closed
adigostin opened this issue Feb 15, 2019 · 0 comments
Closed

Restarting the state machines not always correct #13

adigostin opened this issue Feb 15, 2019 · 0 comments
Assignees

Comments

@adigostin
Copy link
Owner

adigostin commented Feb 15, 2019

When BEGIN is asserted, for example due to changing the protocol version with STP_SetStpVersion(), each state machine must enter a well-defined state and execute the "state entry" code.

Bug: if a state machine is already in that state when BEGIN is asserted, then the "state entry" code is not executed. See this comment in various state machines: // The entry block for this state has been executed already.

Fix: In RestartStateMachines(), force the state of all state machines to "undefined" (value 0) after asserting BEGIN and before running the state machines. This will cause them to always transition to the well-defined state and execute its entry code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant