Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Light Theme Background Color Inconsistencies #369

Closed
jamesgoodhouse opened this issue Apr 18, 2021 · 8 comments
Closed

[BUG] Light Theme Background Color Inconsistencies #369

jamesgoodhouse opened this issue Apr 18, 2021 · 8 comments
Labels
bug Something isn't working no-activity No activity since long time

Comments

@jamesgoodhouse
Copy link

Describe the bug

When in "light" mode, the background color for posts appears to be slightly different than that of the rest of the pages. This inconsistency doesn't appear to exist when in dark mode, so I'm wondering if it's accidental or intentional?

  • Device/Os: MacOS
  • Type: Desktop
  • Browser and version: Chromium: 89.0.4389.114 (Official Build) (x86_64)
  • Hugo Version: 0.82.0
  • Theme Version: master

Steps to reproduce the behavior:

Expected behavior:

I would expect the colors to be consistent across all the different layouts.

Screenshots

Screen Shot 2021-04-17 at 6 35 35 PM

Additional context

@jamesgoodhouse jamesgoodhouse added the bug Something isn't working label Apr 18, 2021
@adityatelange
Copy link
Owner

Yes this is intentional and not accidental.

@jamesgoodhouse
Copy link
Author

oh ok, good to know. any additional context as to why this is the case for just the light theme?

@adityatelange
Copy link
Owner

oh ok, good to know. any additional context as to why this is the case for just the light theme?

It's part of the design to be honest. You can't see the cards specifically if you don't have the bg in light theme, whereas this isn't the case in dark one.

@brianly
Copy link

brianly commented Apr 20, 2021

@adityatelange Is there an easy way to make pages and posts consistent, if you want that appearance?

@adityatelange
Copy link
Owner

@adityatelange Is there an easy way to make pages and posts consistent, if you want that appearance?

IMO there's no point in consistency if it doesn't look good or rather better than what is is rn.

Also I don't want to make any abrupt changes to core colors and design of this theme as people who are currently using it (including myself) like the way it is (maybe not all).

Way out is ofc, people can and they should modify and tweak the theme the way they like it to be (I have also done this..). Hugo offers a flexible templating with a way overriding them easily.

@jamesgoodhouse
Copy link
Author

I made some small tweaks via CSS to attempt to make things consistent. I didn't notice issues with elements not be clear enough or hard to see, but my page is rather basic at the moment.

@brianly
Copy link

brianly commented Apr 20, 2021

@adityatelange That makes sense. I found a fix for my needs by modifying baseof.html, so the body class is "list" in all cases. This will help with further development.

@stale
Copy link

stale bot commented Apr 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the no-activity No activity since long time label Apr 27, 2021
@stale stale bot closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-activity No activity since long time
Projects
None yet
Development

No branches or pull requests

3 participants