-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Background Color Mismatch in Light Mode #1418
Comments
Hi, I noticed the problem in the page of @ibrahimcetin , and reproduced the same background-collision, as @LucyLikesYourFace mentions. The solution of @ibrahimcetin shows some fallback background-color settings ( either of |
I tried some modification like this:
|
This is intended, not a bug. |
Describe the bug
Background color mismatch on single page in light mode with profile mode.
Steps to reproduce the behavior:
In light mode, you can easily see the background color mismatch when switching between the home and about tabs on my website.
Expected behavior:
All pages background color should be the same.
Repo/Source where this issue can be reproduced:
My website: https://ibrahimcetin.dev
Source code: https://github.com/ibrahimcetin/ibrahimcetin.dev
Screenshots
I think the difference is clear, about page has a lighter background color.
Additional context
I'm using profile mode on my website, but the about page has a background color mismatch in light mode. I noticed that the about page, being a single page, doesn't have the class="list" attribute on its body tag. When I manually add the class, everything seems okay.
Proper Solution
I a bit dived into the theme's source code and fixed the issue by modifying this line.
To resolve the issue, I introduced a new layout named
single
inabout.md
to distinguish it from other layouts. Additionally, I added(eq .Layout `single`))
to the mentioned line. This simple addition seems to have fixed the problem. However, since I'm not familiar with the theme's internals, I am not sure this is the solution. If it is, I can create a pull request.The text was updated successfully, but these errors were encountered: