Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make contacts mdJSON 2.0 compatible #64

Closed
11 tasks
jlblcc opened this issue Mar 1, 2017 · 1 comment
Closed
11 tasks

Make contacts mdJSON 2.0 compatible #64

jlblcc opened this issue Mar 1, 2017 · 1 comment
Assignees
@jlblcc
Labels
enhancement Improve or modify an existing feature
Projects
mdEditor Initial Release

Comments

@jlblcc
Copy link
Member

jlblcc commented Mar 1, 2017

The contacts model & components need to be updated to be compatible with mdJSON 2.0.

  • In 2.0 there is only one schema for both types of contacts. The required isOrganization property determines the type of contact.
  • Rules for name have changed, see mdTools
  • positionName will only be valid for individual contacts.
  • It's now possible to assign contacts to an organization
  • Support was added for logos
  • Address is now an array
  • phoneBook changed to phone
  • hoursOfService was added as an array of character strings.
  • contactType was added as a user defined contact type (might want to have this as an editable select).
  • electronicMailAddress is an array of strings. It was moved to the base of 'contact' from 'address'.
  • contactInstructions added

Refer to adiwg/mdJson-schemas/issues/48.
@jlblcc jlblcc added the enhancement Improve or modify an existing feature label Mar 1, 2017
@jlblcc jlblcc added this to the v1.0.0-rc milestone Mar 1, 2017
@jlblcc jlblcc self-assigned this Mar 1, 2017
@jlblcc jlblcc added this to TODO in mdEditor Mar 6, 2017
@jlblcc
Copy link
Member Author

jlblcc commented Mar 7, 2017

Some UI mockups.

contacts_pencil.zip

Add Person

add_person

Add Organization

add_organization

Edit Person (w/ScrollSpy)

editing_person

@jlblcc jlblcc moved this from TODO to In Progress in mdEditor Mar 7, 2017
@jlblcc jlblcc removed this from In Progress in mdEditor Mar 7, 2017
@jlblcc jlblcc added this to In Progress in mdEditor Mar 10, 2017
@jlblcc jlblcc added this to Mandatory in Initial Release May 2, 2017
@dwalt dwalt moved this from Mandatory to Desired in Initial Release May 2, 2017
@jlblcc jlblcc moved this from Desired to Mandatory in Initial Release May 2, 2017
@jlblcc jlblcc moved this from Mandatory to In Progress in Initial Release May 12, 2017
@jlblcc jlblcc closed this as completed Feb 15, 2018
@jlblcc jlblcc moved this from In Progress to Done in Initial Release Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlblcc jlblcc

Labels
enhancement Improve or modify an existing feature
Projects
Initial Release
  
Done
mdEditor
In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlblcc