-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cordova build fails after adding adjust plugin #40
Comments
Maybe some of the plugins is already using that part of Google Play Services which is needed for our SDK. Please check our Google Play Services guide from README: https://github.com/adjust/cordova_sdk/#4-google-play-services Feel free to follow this part about removing Google Play Services dependency from our plugin and retry. Let me know if that worked for you. Cheers |
man that really looks like it should fix this, but unfortunately I'm still getting the same error. I tried to edit the But after both cases I still get the same error :( tnx for the quick reply btw :) |
Hm, I tried to recreate your plugin list, I think error relates to one of these two plugins:
For example, once adding them (just adding them, not using them at all), I am unable to build my app. I am getting following error:
followed by bunch of errors saying that different symbols can't be found or that some particular package doesn't exist, etc. Any idea how to solve this maybe so that I might be able maybe to reproduce error you're getting? |
I'm adding those plugins in the following way:
then I'm able to build |
Adding the Adjust plugin after those two already gives the |
I can build if I remove the |
Okay, managed to reproduce the error you are facing, indeed with It looks like things in
After that, my app was successfully built with Let me know if this worked for you. |
alas, it doesn't seem to have any effect over here, I removed and added the android platform both on my full list of plugins and on the test project with only chromecast and adjust, both still give the same error. I also tried removing the plugins and adding them in different orders. |
Hm. :) Funky stuff. After retrying, would be interesting if you can check following part after doing:
When building, gradle builds stuff and among other lines, you can see these:
If you build your app w/o our plugin, they look exactly like this, because it looks like that
Since our plugin aims to put latest Now, to fix this, try this:
Let me know if it worked in this way. :) |
Hey @uerceg, I'll be taking over the issue from Marcus as I'm the engineer working on our automated build script(s). It seems you're right, I have the same lines in the build log and removing the Google Play Services from the plugin.xml file results in a successful build. It would be a great feature if we could specify the Google Play Services version to use when installing the plugin. This would also prevent problems should Google break the Google Play Services interface in a future release. We've faced numerous problems with wildcard version numbers in previous Cordova releases, so we're very keen on fixating the version so that we can test before updating to a new version. For the time being we'll just create a fork in which we'll modify the plugin.xml, but I'd love to hear what your thoughts are on a feature to allow users to fixate the version :) |
P.S. I've tried adding a preference field to the plugin, but for some reason the variable doesn't get replaced with the specified value. I've applied these changes;
Adding the plugin with |
Hi @tvervest And sorry for delayed answer. Making possibility for users to pass the value of Google Play Services version sounds like an interesting idea. I have tried to do the same thing as you, but no luck either. If I try to declare <!-- .... -->
<preference name="GPS_VERSION" />
<!-- .... -->
<!-- Android -->
<platform name="android">
<!-- .... -->
<framework src="com.google.android.gms:play-services-analytics:$GPS_VERSION" />
</platform>
<!-- .... --> and if I add our plugin with:
I indeed get <framework src="com.google.android.gms:play-services-analytics:$GPS_VERSION" /> doesn't seem to work for some reason. Did you maybe find a way to make it work? Cheers |
Hey @uerceg, that was exactly where I got stuck :) I haven't figured out why it didn't work, but I'm afraid it might be a bug/feature of Cordova. It seems the |
Yep, that was pretty much my conclusion after trying to make this happen today. :) I will ping you in here if I manage to find solution for it. Other than that, any reason still not to close this issue? |
Great, if I ever find out what was going on exactly I'll update this as well 👍 No reasons not to close this issue, feel free to do so :) |
👍 Cheers! |
I'm adding the adjust plugin
4.3.0
to a project with only theAndroid
platform. After adding the plugin, runningcordova build
fails with the following error:If I create a fresh Cordova project and only add the Adjust plugin, there is no problem building, so I know the error must be following from some sort of conflict with one or more if the existing plugins in my app.
I will continue to debug this problem and I will update when I've figured out exactly which plugin(s) is/are conflicting with adjust.
I was wondering if there is anything that could be done on the adjust plugin level to avoid this type of conflict. Maybe in the way it declares/adds this library?
The complete list of plugins now looks like this:
running Cordova
6.1.1
The text was updated successfully, but these errors were encountered: