Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Constraint AASD-120 for SMT allow idShort in SML #432

Open
BirgitBoss opened this issue May 22, 2024 · 2 comments
Open

Relax Constraint AASD-120 for SMT allow idShort in SML #432

BirgitBoss opened this issue May 22, 2024 · 2 comments
Labels
requires workstream approval strategic decision in spec team needed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented May 22, 2024

Is your feature request related to a problem? Please describe.
For Submodel Template creation it is helpful to have an idShort for the element type within the SML.
This is mainly the case for SML of SMC or SML because there are separate tables for SMC and SML. For properties it is more difficult.
See discussion in admin-shell-io/submodel-templates#65

Constraint AASd-120: idShort of submodel elements being a direct child of a SubmodelElementList shall not be specified.

could be relaxed to

Constraint AASd-120: idShort of submodel elements being a direct child of a SubmodelElementList shall not be specified within Submodels with kind=Instance.

Describe alternatives you've considered

  • do not relax
    -- instead create ConceptDescriptions with idShort of the corresponding elements

  • remove completely, i.e. also allow idShort in Submodels with kind=Instance for better readability

AASd-120 was a further restriction of
Constraint AASd-117: idShort of non-identifiable Referables not being a direct child of a SubmodelElementList shall be specified.

@BirgitBoss BirgitBoss added specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally requires workstream approval strategic decision in spec team needed labels May 22, 2024
@BirgitBoss BirgitBoss changed the title Relax Constrain AASD-120 for SMT allow idShort in SML Relax Constraint AASD-120 for SMT allow idShort in SML May 22, 2024
@BirgitBoss BirgitBoss added this to the V3.1 milestone May 23, 2024
@BirgitBoss
Copy link
Collaborator Author

TF Part 1 2024-06-12 Decision Proposal:
remove AASd-120

@BirgitBoss BirgitBoss added ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream accepted accepted in principle to be fixed requires workstream approval strategic decision in spec team needed and removed requires workstream approval strategic decision in spec team needed ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream accepted accepted in principle to be fixed labels Jun 12, 2024
@BirgitBoss
Copy link
Collaborator Author

Accepted in principle by Workstream AAS Spec. 2024-06-13
Comments:

  • within a Submodel with kind=Instance idShorts need to be unique. For SMT there is only exactly one element allowed to be part of the SML.
  • However, in idShortPath idShort of SML elements shall not be used (because you cannot rely that the idShort exists)
  • In ValueOnly Format of API idShort will not be used (it is an JSON array)
  • even consider to make idShort mandatory for SML elements as well (then it could be used in idShortPath as well) However, this is not backward compatible
  • Part 2 affected as well, is there a need to add a corresponding comment in Part 2

TF AAS Part 1 will discuss this issue again and make a proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires workstream approval strategic decision in spec team needed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

No branches or pull requests

1 participant