Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save AAS which has an Operation in Submodel Template #148

Open
STUBA-rupr opened this issue Sep 22, 2023 · 6 comments
Open

Cannot save AAS which has an Operation in Submodel Template #148

STUBA-rupr opened this issue Sep 22, 2023 · 6 comments
Assignees
Labels
bug Something isn't working InProgress This is actively being worked on

Comments

@STUBA-rupr
Copy link

Describe the bug
After I add an Operation under a Submodel template I cannot save the AASX file, and cannot do check validate fix as well.

To Reproduce
Steps to reproduce the behavior:

  1. Get for instance AAS from IDTA 02008-1-1_Template_withOperations_TimeSeriesData.aasx
  2. Add a new Operation to the submodel e.g. Oper01
  3. Try to save

Expected behavior
I would expect that aasx file is updated. But it is not the case.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows Server 2022
  • Browser Edge, Chrome
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@STUBA-rupr
Copy link
Author

I figured out that there MUST be defined at least ONE INPUT, ONE OUTPUT and ONE IO.
Then it is possible to save the AASX.
image

@wiresio
Copy link

wiresio commented Oct 16, 2023

See also: admin-shell-io/aasx-package-explorer#635

And thanks for the hint!

@MichaelHoffmeisterFesto
Copy link
Contributor

In this branch I added a fix: https://github.com/admin-shell-io/aasx-package-explorer/tree/MIHO/TMV30_SAMM_Xmas2023
See: https://github.com/admin-shell-io/aasx-package-explorer/commit/f3cf9337f1668f41735be271eeed068ba3d63148
Changes to: src/AasxCsharpLibrary/Extensions/ExtendISubmodelElement.cs
Right now, I dont known when it is integrated to the main brnach.

@wiresio
Copy link

wiresio commented Jan 30, 2024

Thank you @MichaelHoffmeisterFesto - it is working for me!

@STUBA-rupr
Copy link
Author

Thank you as well, nice Xmas gift!

@wiresio
Copy link

wiresio commented Jan 30, 2024

Should be kept open since it is not yet merged into main!

@STUBA-rupr STUBA-rupr reopened this Jan 30, 2024
@martafullen martafullen transferred this issue from admin-shell-io/aasx-package-explorer Feb 16, 2024
@martafullen martafullen transferred this issue from another repository Feb 21, 2024
@juileetikekar juileetikekar added the InProgress This is actively being worked on label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working InProgress This is actively being worked on
Projects
None yet
Development

No branches or pull requests

5 participants