Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to create as AASX file with 2 AAS models that have the same ID #164

Closed
WelliSolutions opened this issue Dec 15, 2023 · 1 comment
Closed

Possible to create as AASX file with 2 AAS models that have the same ID #164

WelliSolutions opened this issue Dec 15, 2023 · 1 comment
Assignees
@AlexanderWollbrink
Labels
bug Something isn't working InProgress This is actively being worked on

Comments

@WelliSolutions
Copy link

Describe the bug
With AASX Package Explorer, it's possible to create an AASX file that contains 2 AAS, each having the same id and each having AssetInformation with the same globalAssetId.

To Reproduce
Steps to reproduce the behavior:

  1. File/New
  2. Workspace/Edit
  3. Click AdministrationShells
  4. Add AAS and assign AAS1 as id
  5. Click AssetInformation and assign AAS1Info1 as globalAssetId.
  6. Repeat steps 3 through 5 in order to get exact duplicates.
  7. Save the work as AASX file

Expected behavior
It's not possible to have two AAS in one AASX file with the same ID.
The basyx-python-sdk can't access both AAS models with the same ID because it uses a dictionary and accesses them by ID.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10

Additional context
AASX Package Explorer v2023-11-17
@WelliSolutions WelliSolutions changed the title Possible to create as AASX file with 2 AASX that have the same ID Possible to create as AASX file with 2 AAS models that have the same ID Dec 15, 2023
@martafullen martafullen added the bug Something isn't working label Feb 7, 2024
@AlexanderWollbrink AlexanderWollbrink mentioned this issue Feb 7, 2024
Closed
@martafullen martafullen mentioned this issue Feb 7, 2024
Merged
@martafullen martafullen transferred this issue from admin-shell-io/aasx-package-explorer Feb 16, 2024
@martafullen martafullen transferred this issue from another repository Feb 21, 2024
@juileetikekar juileetikekar added the InProgress This is actively being worked on label Mar 19, 2024
@juileetikekar
Copy link
Contributor

PR #185 closes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderWollbrink AlexanderWollbrink

Labels
bug Something isn't working InProgress This is actively being worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@WelliSolutions @AlexanderWollbrink @martafullen @juileetikekar