Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old release v1.1.2 is marked as latest #265

Closed
jesusfcr opened this issue Jun 15, 2023 · 10 comments · Fixed by #267
Closed

Old release v1.1.2 is marked as latest #265

jesusfcr opened this issue Jun 15, 2023 · 10 comments · Fixed by #267
Assignees

Comments

@jesusfcr
Copy link
Contributor

jesusfcr commented Jun 15, 2023

Hi @Admiral-Piett

First, thanks for taking the time of maintaining this project.

Looking into the releases/tags of the project I see they are not congruent with the dates.

go list -versions -m github.com/Admiral-Piett/goaws
github.com/Admiral-Piett/goaws v0.2.0 v0.2.1 v0.2.2 v0.3.0 v0.3.1 v0.3.2 v0.4.0 v0.4.1 v1.1.0 v1.1.1 v1.1.2

go get github.com/Admiral-Piett/goaws@latest
go: added github.com/Admiral-Piett/goaws v1.1.2

It seems clear the last one is the v0.4.1, so the v1 releases are interfering.

This could be solved by retracting the v1 versions just adding that on your go.mod.

retract (
        v1.1.0
        v1.1.1
        v1.1.2
)
@goddenrich
Copy link

goddenrich commented Apr 3, 2024

Hi @Admiral-Piett I am still seeing the old version as latest and it appears the retractions are not doing what they are intending to do

$ go list -versions -m github.com/Admiral-Piett/goaws
github.com/Admiral-Piett/goaws v0.2.0 v0.2.1 v0.2.2 v0.3.0 v0.3.1 v0.3.2 v0.4.0 v0.4.1 v0.4.2 v0.4.3 v0.4.4 v0.4.5 v1.1.0 v1.1.1 v1.1.2
$ go list -versions -m -retracted github.com/Admiral-Piett/goaws
github.com/Admiral-Piett/goaws v0.2.0 v0.2.1 v0.2.2 v0.3.0 v0.3.1 v0.3.2 v0.4.0 v0.4.1 v0.4.2 v0.4.3 v0.4.4 v0.4.5 v1.1.0 v1.1.1 v1.1.2

from https://pkg.go.dev/github.com/Admiral-Piett/goaws it looks like that is saying the go.mod is invalid

@jesusfcr
Copy link
Contributor Author

Hi, I think this explains the reason why and how to solve it https://www.jvt.me/posts/2024/01/15/retract-go-release/

@goddenrich
Copy link

@jesusfcr if i'm understanding correctly this library needs to tag a new release as v1.1.3 which contains

retract(
     v1.1.0
     v1.1.1
     v1.1.2
     v1.1.3
)

is that correct? If so @Admiral-Piett could you do that?

@jesusfcr
Copy link
Contributor Author

jesusfcr commented Apr 19, 2024

@goddenrich well kind of, I m not an expert so I would follow all the steps described in the link.

@Admiral-Piett
Copy link
Owner

@jesusfcr @goddenrich - let me know if you're still having trouble with this. It's been a real mess - I added a couple minor things and threw a new version out there. It's working for me, but locally I did have to do a go get github.com/Admiral-Piett/goaws@v0.4.7 to get the go module proxy to bypass the 1.1.x versions. I think that should do it though - it's now seeing v0.4.7 as latest for me anyway. Small progress?

@goddenrich
Copy link

goddenrich commented Apr 25, 2024

v1.1.3 still seems to be latest for me but now v1.1.1 and v1.1.2 seem to properly be retracted

$ go list -versions -m github.com/Admiral-Piett/goaws
github.com/Admiral-Piett/goaws v0.2.0 v0.2.1 v0.2.2 v0.3.0 v0.3.1 v0.3.2 v0.4.0 v0.4.1 v0.4.2 v0.4.3 v0.4.4 v0.4.5 v0.4.6 v0.4.7 v0.4.8 v1.1.3
$ go get github.com/Admiral-Piett/goaws@v0.4.7
go: downloading github.com/Admiral-Piett/goaws v0.4.5
go: upgraded github.com/Admiral-Piett/goaws v0.4.6 => v0.4.7
$ go list -versions -m github.com/Admiral-Piett/goaws
github.com/Admiral-Piett/goaws v0.2.0 v0.2.1 v0.2.2 v0.3.0 v0.3.1 v0.3.2 v0.4.0 v0.4.1 v0.4.2 v0.4.3 v0.4.4 v0.4.5 v0.4.6 v0.4.7 v0.4.8 v1.1.3
$ go get -u github.com/Admiral-Piett/goaws
go: upgraded github.com/Admiral-Piett/goaws v0.4.7 => v1.1.3

which is strange give https://pkg.go.dev/github.com/Admiral-Piett/goaws/app?tab=versions seems correct to me

@Admiral-Piett
Copy link
Owner

@goddenrich Try to pull v0.4.7 or v0.4.8 manually (the full command is in my note above). I bet your go module proxy needs to update and get forced onto the new track. Since there is no v1.1.3 anymore.

@goddenrich
Copy link

I think I did (2nd command above) correct me if I'm wrong

@goddenrich
Copy link

ah removing the $GOPATH/pkg/sum.golang.org/latest and rerunning

rgodden@rgodden-tm05522:~/repos/core3/src$ go list -versions -m github.com/Admiral-Piett/goaws
github.com/Admiral-Piett/goaws v0.2.0 v0.2.1 v0.2.2 v0.3.0 v0.3.1 v0.3.2 v0.4.0 v0.4.1 v0.4.2 v0.4.3 v0.4.4 v0.4.5 v0.4.6 v0.4.7 v0.4.8

@jesusfcr
Copy link
Contributor Author

jesusfcr commented May 1, 2024

@Admiral-Piett for me it's as expected.
Thanks a lot for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants