support k8s 1.22+ #139
Merged
support k8s 1.22+ #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e., drop support for k8s 1.17 - 1.20, add support for k8s 1.22 - 1.23 (and likely future versions until something breaks) upgrade go to 1.17 and k8s.io dependencies, controller-runtime, vk, and minor dependencies to latest package versions, luckily cross-compatible (we might have still supported k8s 1.19 - 1.20 with older versions; not worth the maintenance cost) k8s 1.20- aren't supported anymore because schedulers watch PodDisruptionBudgets using the policy/v1 API version, available since v1.21 use the certificates.k8s.io/v1 API version for CertificateSigningRequest use the networking.k8s.io/v1 API version for Ingress use the coordination.k8s.io/v1 API version for Lease upgrade cert-manager, argo, and our own CRDs and webhook configuration because 1.22 dropped support for admissionregistration.k8s.io/v1beta1 and apiextensions.k8s.io/v1beta1 move CRDs to templates/ (from crds/, which is actually meant for CRDs that have objects created in the same chart) so they're updated on helm upgrades (cert-manager did the same move) upgrade to go 1.17 Signed-off-by: adrienjt <adrienjt@users.noreply.github.com>
controller-manager is restarted when target is deleted, so it can take a while to reconcile Signed-off-by: adrienjt <adrienjt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e., drop support for k8s 1.17 - 1.20, add support for k8s 1.22 - 1.23 (and likely future versions until something breaks)
upgrade go to 1.17 and k8s.io dependencies, controller-runtime, vk, and minor dependencies to latest package versions, luckily cross-compatible (we might have still supported k8s 1.19 - 1.20 with older versions; not worth the maintenance cost)
k8s 1.20- aren't supported anymore because schedulers watch PodDisruptionBudgets using the policy/v1 API version, available since v1.21
use the certificates.k8s.io/v1 API version for CertificateSigningRequest
use the networking.k8s.io/v1 API version for Ingress
use the coordination.k8s.io/v1 API version for Lease
upgrade cert-manager, argo, and our own CRDs and webhook configuration because 1.22 dropped support for admissionregistration.k8s.io/v1beta1 and apiextensions.k8s.io/v1beta1
move CRDs to templates/ (from crds/, which is actually meant for CRDs that have objects created in the same chart) so they're updated on helm upgrades (cert-manager did the same move)
fixes #130
fixes #120