Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl attach via proxy pods #150

Open
mhuysamen opened this issue Apr 22, 2022 · 3 comments
Open

kubectl attach via proxy pods #150

mhuysamen opened this issue Apr 22, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@mhuysamen
Copy link

It seems that Admiralty's proxy pods don't support attaching to scheduled candidate pods.

I'm trying to use Admiralty in conjunction with Submariner to bind several k8s clusters, and have AWX spawn automation jobs across them. It seems that AWX, once it launches a worker container, attaches to the container to send it instructions via stdin, and reads output via stdout.

If this isn't currently supported, could this be added, that once the POD is Running, the Proxy pod attaches to the Candidate for stdin/stdout. This could be activated conditionally with an extra annotation, like multicluster.admiralty.io/attach=true, since this functionality would only be required in specific workloads/conditions.

@adrienjt
Copy link
Contributor

We support exec (and logs). So adding attach shouldn't be hard. This was an oversight.

@adrienjt
Copy link
Contributor

Not so fast though. Virtual-Kubelet only supports exec and logs, so we'll have to fork or upstream this piece: https://github.com/virtual-kubelet/virtual-kubelet/blob/master/node/api/server.go

@adrienjt
Copy link
Contributor

adrienjt commented Jul 7, 2023

Attach is now supported by VK: virtual-kubelet/virtual-kubelet#1090

@adrienjt adrienjt added the enhancement New feature or request label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants