Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solutions to variant problems #114

Open
deveshks opened this issue Nov 14, 2019 · 8 comments
Open

Solutions to variant problems #114

deveshks opened this issue Nov 14, 2019 · 8 comments

Comments

@deveshks
Copy link
Contributor

I don't see solutions to variants specified in some of the questions. Is that intentional?

I would be happy to contribute solutions to some of the variants as well

@tsunghsienlee
Copy link
Collaborator

Hi @deveshks ,

We definitely welcome solution to variants; however, the challenge part is that we expect good coding style (like the one you see in the book) also solutions to three languages (as we want to keep consistency).

Those are actually very challenging but if you want to try it, please go ahead!

@deveshks
Copy link
Contributor Author

Hi @tsunghsienlee
Thanks for the clarification. Apart from providing code in three languages, am I also expected to provide tsv files for test cases, and well as test hooks ?

Also what will be the nomenclature for the functions for the variant problems? Is there a nomenclature followed for the other question solutions?

@tsunghsienlee
Copy link
Collaborator

Hi @deveshks ,

We mostly built a test case generator for that. It comes with fixed random seed and integrating with our solution so we use our solution to generate that result.

For now, I would say you should focusing on generating solutions first.

@deveshks
Copy link
Contributor Author

Hi @tsunghsienlee
I will start by taking a stab at some of the variant problems in all 3 languages and create a PR accordingly

@alirezaghey
Copy link

hey @deveshks
Are you interested in sharing the workload with others in terms of programming language?
I know enough Java and C++ to rewrite them in Python while coming up with my own solutions in PY.

@deveshks
Copy link
Contributor Author

Sure, I can write up solutions for variants in Python, if you are able to chip in with solutions in Java/C++

@alirezaghey
Copy link

To make sure I got you right: I provide solutions in Python, or rewrite your Java/C++ solution in Python.
Is that correct?

@deveshks
Copy link
Contributor Author

I was under the impression that you wanted to provide solutions in Java/C++.

I myself am not currently comfortable with Java/C++, but I am well versed with Python, so I can provide solutions in Python, and you provide solutions in Java/C++, and we can take the good bits from both and make PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants