Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: hook rate limiting #120

Closed
antoineco opened this issue Mar 16, 2017 · 4 comments
Closed

Proposal: hook rate limiting #120

antoineco opened this issue Mar 16, 2017 · 4 comments

Comments

@antoineco
Copy link

antoineco commented Mar 16, 2017

first of all thanks for this amazing project! I'm using it to automate all my Docker build pipelines 馃憤

I open this issue to actually suggest a new feature: a per-hook rate limit.

I have a case where a build job is being run multiple times in a row (a test matrix sort of) and sends a request to my hook every time it completes.

Since I know the build job is going to spam my hook at some point I would like to set a rate limit on that hook in order to either:

  • Accept a request but ignore all subsequent requests for X seconds*
  • Accept all requests but only perform the action if no request has been received in the last X seconds*

* I'm talking about valid requests.

Does it sound like a reasonable feature? Would you accept a PR for it?

@adnanh adnanh closed this as completed May 27, 2017
@antoineco
Copy link
Author

antoineco commented May 27, 2017

Oh wow, that was a harsh close :)

@adnanh
Copy link
Owner

adnanh commented May 27, 2017

Thought you saw my 馃憤 :-)

@adnanh
Copy link
Owner

adnanh commented May 28, 2017

Anyways, I'll be more than glad to accept a PR for this feature, as I currently do not have enough time nor resources to dedicate myself to implementing a rock-solid solution to this problem :-)

@antoineco
Copy link
Author

No problem @adnanh, I perfectly understand. I didn't see your thumb up as Github doesn't notify on reactions unfortunately.
Anyway, I moved on since I posted my proposal but I still keep it in a corner of my head! Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants