Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capital figures need better reference in <case> feature. #127

Closed
frankrolf opened this issue Jun 1, 2016 · 2 comments
Closed

Capital figures need better reference in <case> feature. #127

frankrolf opened this issue Jun 1, 2016 · 2 comments
Labels

Comments

@frankrolf
Copy link
Member

frankrolf commented Jun 1, 2016

Analog to adobe-fonts/source-sans#89

Possible fix:

Current:

feature case { # Case-Sensitive Forms
    sub @MARKS_CMB_ALL by @MARKS_CMB_ALL_CASE;
    sub @FIGURES_OLDSTYLE by @FIGURES_CASE;
    sub ijacute by IJacute;
    sub at by at.case;
    sub anoteleia by anoteleia.cap;
} case;

Fix:

feature case { # Case-Sensitive Forms
    sub @MARKS_CMB_ALL by @MARKS_CMB_ALL_CASE;
    sub @FIGURES_LINING by @FIGURES_CASE;
    sub @FIGURES_OLDSTYLE by @FIGURES_CASE;
    sub ijacute by IJacute;
    sub at by at.case;
    sub anoteleia by anoteleia.cap;
} case;
@pauldhunt pauldhunt added the bug label Jun 1, 2016
@frankrolf
Copy link
Member Author

Alternatively, you could also move the onum feature below the case feature, and remove the line
sub @FIGURES_OLDSTYLE by @FIGURES_CASE;

Unlikely all-cap setting & oldstyle figures would interfere with each other.

@pauldhunt
Copy link
Contributor

pauldhunt commented Jun 2, 2016

i think i got it sorted out, but thank you. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants