Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect mappings of 13 倉-composed characters for HK, and some other questions #107

Closed
tamcy opened this issue Oct 26, 2021 · 2 comments

Comments

@tamcy
Copy link

tamcy commented Oct 26, 2021

First off, I want to thank you guys for the release of Source Han Serif 2.0. With the inlcusion of HKSCS codepoints the font is much more usable in Hong Kong.

As v2.000 is a big update, I would like to know if you are still in the middle of handling the opening issues original planned for v2.000 because I spot some unfixed issues originally targeted for post-v1.001, and some issues fixed in v1.001 got reverted. If yes I won't bother raising them again.

And would you like us to report glyph mapping/design issues separately (one issue per codepoint or codepoints with common factors, like this issue contains bugs about characters with a 倉 component), or consolidate them in a single thread (until they are closed by your side)?


Going back to the topic, the third stroke of the component 倉 for should be a horizontal line for JP, KR, TW and HK. This is different from CN which is a dot. Follow screenshot shows a correct example:

cong1

But the following 13 characters are incorrectly mapped to the CN glyph:

cong

I mainly check for issues against the new HK region, but this issue also affects TW. Here is the proposed fix:

# Codepoint Current glyph Remap suggestion
1 U+5096 傖 uni5096-CN -> uni5096-JP
2 U+51D4 凔 uni51D4-CN -> uni51D4-JP
3 U+5275 創 uni5275-CN -> uni5275-JP
4 U+55C6 嗆 uni55C6-CN -> uni55C6-JP
5 U+6134 愴 uni6134-CN -> uni6134-JP
6 U+6227 戧 uni6227-CN -> uni6227-JP
7 U+6436 搶 uni6436-CN -> uni6436-JP
8 U+69CD 槍 uni69CD-CN -> uni69CD-JP
9 U+6EC4 滄 uni6EC4-CN -> uni6EC4-JP
10 U+7472 瑲 uni7472-CN -> uni7472-JP
11 U+8E4C 蹌 uni8E4C-CN -> uni8E4C-JP
12 U+9397 鎗 uni9397-CN -> uni9397-JP
13 U+9DAC 鶬 uni9DAC-CN -> uni9DAC-JP
@tamcy tamcy changed the title Incorrect mappings of 13 倉-composed characters for HK, and some other questions Incorrect mappings for 13 倉-composed characters for HK, and some other questions Oct 26, 2021
@tamcy tamcy changed the title Incorrect mappings for 13 倉-composed characters for HK, and some other questions Incorrect mappings of 13 倉-composed characters for HK, and some other questions Oct 26, 2021
@punchcutter
Copy link
Member

Yes, we are still planning to address issues that were marked for post 1.001 and didn't get addressed yet.
If any issues fixed in v1.001 got reverted then that wasn't intentional, but with the large number of files and a completely redesigned build workflow it's not too surprising if some things slipped through. Please open issue for any of those so I can check where things went wrong.

I would very much like to get away from the long consolidated issues, but when addressing common factors it makes sense. I plan to update the templates to hopefully make it a little easier to start an issue specifically addressing mapping, glyph correction, glyph addition, etc.

@tamcy
Copy link
Author

tamcy commented Jan 27, 2022

Confirmed fixed in v2.001.

@tamcy tamcy closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants