Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for minor change to STAT feature syntax #1197

Closed
josh-hadley opened this issue Jul 28, 2020 · 3 comments · Fixed by #1213
Closed

Proposal for minor change to STAT feature syntax #1197

josh-hadley opened this issue Jul 28, 2020 · 3 comments · Fixed by #1213

Comments

@josh-hadley
Copy link
Collaborator

josh-hadley commented Jul 28, 2020

We (Adobe FDK developers) are considering a minor (but breaking) change to the Feature File Specification for defining range-based STAT AxisValues (known as ‘location format B’ in the Feature File Spec and ‘Format 2’ in the OpenType spec).
The original proposal (here) and current implementation use a hyphen (-) to separate <rangeMinValue> and <rangeMaxValue>. After some testing and discussion here, it turns out that the hyphen is not necessary.

Removing the hyphen from the Feature File specification:

  • makes parsing less complicated
  • makes the documentation simpler
  • makes the .fea code cleaner:
    # format 2
    AxisValue {
        location wght 400 300 500;
        nameRegular”;
        flag ElidableAxisValueName;
    };

We wanted to make folks aware of this likely change and give an opportunity to discuss, in the unlikely event that this would have an untenable impact on workflows or other implementations (@punchcutter has work-in-progress on the fontTools implementation of this and will update that work with this change, if applicable).

To be clear: we are not talking about changing any aspect of the OpenType specification. This is applicable only to the AFDKO Feature File Specification, and only for STAT AxisValue location format B.

At worst, we expect the impact would be that STAT table definitions in .fea files using the currently defined (as of AFDKO 3.5.0) range-based AxisValue format would need to remove the - from any such range definitions in order to be correctly parsed with the updated makeotfexe.

cc: @sairuspatel @khaledhosny

@twardoch
Copy link

At FontLab, we have not yet incorporated the new AFDKO but we're looking forward to adopt it, and we support the change.

@khaledhosny
Copy link
Collaborator

I have no objection.

@anthrotype
Copy link
Member

sounds good to me

@punchcutter punchcutter linked a pull request Aug 24, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants