Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused image assets #32

Closed
yoshikinoko opened this issue Dec 6, 2018 · 5 comments
Closed

Remove unused image assets #32

yoshikinoko opened this issue Dec 6, 2018 · 5 comments

Comments

@yoshikinoko
Copy link
Contributor

e.g., remove *@2x.png, *@3x.png files from the project

  • e2e-adobe-stock/assets
  • ui-playground/welcome/pages/assets
  • ui-buttons-galore/
  • sg-lots-of-rects/images/

Although, keep files in this project. This is the example that explains the plugin manager's behavior (use the largest of the icons listed).

  • ui-dialog-variations/
@peterflynn
Copy link
Contributor

@yoshikinoko Are you sure it's correct to remove those? Does UXP not automatically pick up @2x images the way a browser does?

@kerrishotts
Copy link
Contributor

It does, but iirc in those particular projects, we don’t reference some of the assets at all — so those can just go away.

@peterflynn
Copy link
Contributor

peterflynn commented Dec 6, 2018

Ah ok -- so this is less about multi-scale assets and more just about assets that are entirely unused in general.

@yoshikinoko
Copy link
Contributor Author

@peterflynn
Sorry, updated issue title Remove unused multi-scaled images to Remove unused image assets

@yoshikinoko yoshikinoko changed the title Remove unused multi-scaled images Remove unused image assets Dec 7, 2018
@dkstevekwak
Copy link
Collaborator

removed the unused images from the assets folder:
080f342

kerrishotts added a commit that referenced this issue Nov 14, 2020
Update known issues & changelog for XD 13 public build release candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants