Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LightService from light-service to light_service #62

Open
adomokos opened this issue May 18, 2015 · 9 comments
Open

Rename LightService from light-service to light_service #62

adomokos opened this issue May 18, 2015 · 9 comments

Comments

@adomokos
Copy link
Owner

This is the recommended naming pattern. I chose light-service based on a blog post I read at the time when I started LightService, but I think now that the name is misleading.

I am not alone with this unique naming convention. The project RestClient follows the same naming convention.

I would be curious to see what other folks are thinking about the possibility of renaming the gem from light-service to light_service.

@padi
Copy link
Contributor

padi commented May 18, 2015

Also noticed this before. Never bothered opening an issue for it, but 👍

@ramontayag
Copy link
Contributor

Yes, light_service, since the project isn't Light::Service.

@variousred
Copy link

👍

@adomokos
Copy link
Owner Author

This is actually not all that easy. There is no rename in RubyGems, I have to close the current LightService repo, open up a new one with the new name and continue development on that. Which might make sense as we approach 1.0.

Does anybody else have a simpler, less invasive resolution to this?

@jeroenvisser101
Copy link

How about making a new one and publishing to both, abandoning (possibly with deprecation warnings to STDOUT) the old?

@adomokos
Copy link
Owner Author

That's a pretty good idea! Thank you for suggesting that.

@jeroenvisser101
Copy link

jeroenvisser101 commented Jun 16, 2016

@adomokos thanks — I haven't tested that yet, but in theory, it should work.

@gee-forr
Copy link
Contributor

gee-forr commented Oct 9, 2016

Apologies for the bump on an ancient issue, but I would also add a spec.post_install_message to the gemspec for the deprecated version.

There are docs for post_install_message functionality.

@adomokos
Copy link
Owner Author

I think we know what we want to do with this. I am proposing closing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants