Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on rollback #3

Open
bkmo opened this issue Aug 24, 2023 · 10 comments
Open

Error on rollback #3

bkmo opened this issue Aug 24, 2023 · 10 comments

Comments

@bkmo
Copy link

bkmo commented Aug 24, 2023

I am getting this on rollback with efi part mounted to /boot/efi and a boot partition mounted to /boot:
Removing contents of /boot... Error in rollback: [Error: EBUSY: resource busy or locked, rmdir '/boot/efi'] { errno: -16, code: 'EBUSY', syscall: 'rmdir', path: '/boot/efi' System was rendered not bootable, dropped to grub shell.

I am going to do an install with an encrypted /boot and see how it goes without the unencrypted /boot partition.
Same error with encrypted boot. It is something with node-snapback because snapper-rollback is functioning properly.

@adonespitogo
Copy link
Owner

adonespitogo commented Aug 25, 2023

This does not currently work with if your ESP is not the /boot directory.

@adonespitogo
Copy link
Owner

This is the current implementation of rollback command, perhaps you can try to debug it on your end.

@bkmo
Copy link
Author

bkmo commented Aug 25, 2023

I have 2 partitions one is the EFI mounted to /boot/efi and the other is boot mounted to /boot. So there seems to be an issue with the way it is handling /boot/efi.

@adonespitogo
Copy link
Owner

Yes definitely there's an issue. The script is trying to rm -rf /boot/* during rollback. But your /boot contains mounted partition which cannot be removed, hence the error.

@bkmo
Copy link
Author

bkmo commented Aug 25, 2023

I see where it would work as designed if you have a "Pure" arch install with the /boot residing on the same partition as the ESP. I am testing on a VM with a calamres install that is setup to install the bootloader (grub) at /boot/efi

@adonespitogo
Copy link
Owner

Hi, I think by not removing the contents of /boot, it will work with your setup. Can you try to update to v1.1.1 and see if works?

@bkmo
Copy link
Author

bkmo commented Aug 25, 2023

I will work on it later this evening, or tomorrow.

@bkmo
Copy link
Author

bkmo commented Aug 25, 2023

version 1.1.1 did not give me an error and performed the rollback. I was thinking this tool might make it easy to boot from snapshots without having kernel module mismatches after a kernel update. But this is not the case. Only the backup that is created from the tool is going to boot properly after a kernel update. I will just stick with keeping a locked version of kernel install to boot from snapshots.

@adonespitogo
Copy link
Owner

If you can find a way to hook the backup script to your work flow, then you will be able to rollback successfully. The backup script is located at /usr/local/bin/bootbackup.sh.

@adonespitogo
Copy link
Owner

I've added more targets to the hook as suggested in #2

If you have the chance, try to update to version 1.1.2 and do sudo snapback install again to install the new pacman hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants