Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#86 breaks current installs #88

Closed
raytiley opened this issue Jul 13, 2015 · 2 comments
Closed

#86 breaks current installs #88

raytiley opened this issue Jul 13, 2015 · 2 comments

Comments

@raytiley
Copy link

I'm not super familiar with managing dependencies in addons but I think ember-new-computed needs to be in dependencies and not devDependencies.

Our builds broke with the new release that included the ember-new-computed (#86 ) as a dependency because npm install wasn't triggering the dependency to be installed.
@poteto
Copy link
Collaborator

poteto commented Jul 13, 2015

Yeah you're right, it should be dependency. I'll push a fix shortly. Thanks for reporting!

@poteto poteto mentioned this issue Jul 13, 2015
Merged
@poteto
Copy link
Collaborator

poteto commented Jul 13, 2015

@raytiley Let me know if https://github.com/poteto/ember-cli-flash/releases/tag/1.3.3 resolves your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raytiley @poteto