Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components not wrapped in HMR container #104

Open
joshkadis opened this issue Dec 3, 2018 · 4 comments
Open

Components not wrapped in HMR container #104

joshkadis opened this issue Dec 3, 2018 · 4 comments

Comments

@joshkadis
Copy link

Howdy, thanks @toranb and crew for your work on this! I'm finding that my components are not being wrapped in the HMR containing element. Any thoughts on why this would be the case?

I imagine you'd need some additional info in order to answer that; I'm new to Ember so let me know what details I can provide. Thanks 🙌

@toranb
Copy link
Collaborator

toranb commented Dec 3, 2018

@joshkadis hey thanks for writing! This addon only works with ember-cli < 3.4 :) so assuming you are between ember 2.12-3.3 .... did you run the ember install command? As part of that execution did you say "yes" or "no" to the question about updating your resolver?

@joshkadis
Copy link
Author

Using ember-cli: 3.1.3, installed with ember install, resolver.js looks like the example you provided. It looks like this shouldn't matter any longer, but my environment is called local instead of development

@lifeart
Copy link
Contributor

lifeart commented Dec 9, 2018

@joshkadis you can try ember-ast-hot-load addon

@toranb
Copy link
Collaborator

toranb commented Dec 10, 2018

@joshkadis could you reproduce the issue in a tiny ember app? I'd be happy to look it over at some point but without a broken ember-cli baseline it might be tough to diagnose the issue.

Also, the work @lifeart is doing might be of interest. He is a more active maintainer and his project works with ember-cli 3.4+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants