Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can README specify supported/tested browsers, Ember versions, etc.? #190

Open
lupestro opened this issue May 27, 2020 · 2 comments
Open

Comments

@lupestro
Copy link

I'm glad to see this project reawaken, but I don't know if it will work for us. Are IE11 and old Edge supported by the reawakened addon? What about Ember versions? How far back? Maybe this could go up near the installation section, where people are deciding whether to install it or not.

@Alonski
Copy link
Member

Alonski commented Jun 10, 2020

@lupestro Good idea :) Unfortunately I personally don't have the time to create something like this and it is something that hard to maintain. If you, or someone else, is up to the task I will gladly merge in PRs related to this :)

@fredjohnd
Copy link

If it helps I'm using Ember 2.8.3 and it didn't work for me because the layout helpers are using the new modular imports:

import { helper } from '@ember/component/helper';
import PercentageColumns from 'ember-collection/layouts/percentage-columns';

export default helper(function (params) {
  return new PercentageColumns(params[0], params[1], params[2]);
});

I had to create my own helper with the old format:

import PercentageColumns from 'ember-collection/layouts/percentage-columns';

export default Ember.Helper.helper(function(params) {
  return new PercentageColumns(params[0], params[1], params[2]);
});

I'm also using the alpha 8 version. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants