Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array-observers deprecation #210

Open
nwhittaker opened this issue Jan 7, 2022 · 1 comment
Open

array-observers deprecation #210

nwhittaker opened this issue Jan 7, 2022 · 1 comment

Comments

@nwhittaker
Copy link

The ember-collection component is triggering the array-observers deprecation. This may be a blocker for Ember 4 upgrades.
@lukemelia
Copy link
Collaborator

Based on the code, it will not call addArrayObserver if it is not defined (as is the case under 4.x). This passes all the tests, but I'm not sure if there might be any issues that are not covered by tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukemelia @nwhittaker