Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage without ember-data leads to warning message #563

Closed
jnfingerle opened this issue Feb 9, 2018 · 2 comments
Closed

Usage without ember-data leads to warning message #563

jnfingerle opened this issue Feb 9, 2018 · 2 comments

Comments

@jnfingerle
Copy link

Environment

  • Ember Version: 2.18.0
  • Ember CLI Version: 2.18.1
  • Ember CP Validations Version: 3.5.1

Steps to Reproduce

  • Generate an Ember project
  • Remove ember-data
  • Do any validation
  • In the cosole you see a warning "Ember-Data is required to use the DS Error validator."

Maybe validators that require specific additional libraries should be opt-in?
@offirgolan
Copy link
Collaborator

offirgolan commented Feb 10, 2018 •
edited
Loading

That shouldnt be the case but I'll take a look!

Edit:
By that I mean, it is already setup to be opt-in.

@offirgolan
Copy link
Collaborator

Resolved by #564. Released in v4.0.0-beta.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@offirgolan @jnfingerle